Skip to content

Update mkdocs.yml to fix link problem#252

Open
chrisb13 wants to merge 3 commits intomainfrom
250_cb-fix_link_on_landing_page
Open

Update mkdocs.yml to fix link problem#252
chrisb13 wants to merge 3 commits intomainfrom
250_cb-fix_link_on_landing_page

Conversation

@chrisb13
Copy link
Copy Markdown
Contributor

@chrisb13 chrisb13 commented Oct 30, 2025

Closes: #250 (if works)

As suggested by @atteggiani here: #250 (comment)

@chrisb13 chrisb13 requested a review from Whyborn October 30, 2025 02:44
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 30, 2025 •
edited
Loading

PR Preview
🚀 Preview of PR head commit 16eb973 deployed to https://access-nri.github.io/access-esm1.6-configs/pr-previews/252
2026-04-17 11:24 AEST
Preview generated through the Deploy to GitHub Pages workflow run 24542856443.

@chrisb13 chrisb13 mentioned this pull request Oct 30, 2025
Open
atteggiani
atteggiani requested changes Oct 30, 2025
View reviewed changes
Comment thread documentation/mkdocs.yml Outdated
@chrisb13 @atteggiani
Update documentation/mkdocs.yml
3de0dbd 
Co-authored-by: Davide Marchegiani <davide.marchegiani@gmail.com>
@chrisb13
Copy link
Copy Markdown
Contributor Author

chrisb13 commented Oct 30, 2025

Thanks @atteggiani

@atteggiani atteggiani mentioned this pull request Nov 21, 2025
Merged
17 tasks
@ccarouge
Copy link
Copy Markdown
Member

ccarouge commented Nov 24, 2025

I've added the plugin to the requirements.txt file so that it now builds fine.

@ccarouge ccarouge requested a review from atteggiani November 24, 2025 00:49
@ccarouge
Copy link
Copy Markdown
Member

ccarouge commented Nov 24, 2025

@Whyborn this is now building fine for the preview. Please check it solves the issue #250

Whyborn
Whyborn reviewed Nov 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Whyborn Whyborn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it resolves the fundamental problem, which was incorrect resolution of absolute links, but the Inputs and Configuration/Configuration choices pages still lead to 404s, just because the links in the top index.md are incorrect (There is no /inputs/Forcing-data-models nor /configurations/Overview). Not sure if you want to fix this here, as it's a different problem.

@ccarouge
Copy link
Copy Markdown
Member

ccarouge commented Nov 24, 2025

(There is no /inputs/Forcing-data-models nor /configurations/Overview). Not sure if you want to fix this here, as it's a different problem.

I would leave this to a PR updating the Home page.

@Whyborn Whyborn self-requested a review November 24, 2025 03:53
Whyborn
Whyborn approved these changes Nov 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Whyborn Whyborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat that the remaining broken links (which are broken due to pages actually not existing, rather than absolute links not being resolved) will be fixed in a later PR, this looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Whyborn Whyborn Whyborn approved these changes

@atteggiani atteggiani Awaiting requested review from atteggiani

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Top level docs links lead to 404

4 participants

@chrisb13 @ccarouge @Whyborn @atteggiani
⚡